Comments on: Mercurial trac commit hook

By: math

math — Fri, 30 Oct 2009 14:35:07 +0000

Hmm, just copying the trachook.py to the place gave me an permission error, that normal users which checkin doesn’t have the permission to change /srv/trac/myProject files. How did you solved this??

By: hyper

hyper — Tue, 04 Aug 2009 09:32:48 +0000

I kept getting import errors on trachook, eve though i could import successfully into a python shell. I think it had something to do with my PYTHONPATH not being the same as the webserver user's one.

I fixed the import problem by using a more explicit syntax: In ~/.hgrc:

[extensions] trachook = /full/path/to/trachook.py

then in your repository-specific hgrc, follow the syntax exactly as shown in the original entry.

By: Mads Sülau Jørgensen

Mads Sülau Jørgensen — Tue, 07 Apr 2009 11:59:18 +0000

I’ve givin you write acess to the repository, should you want to maintain it (better than moving it imo) :)

By: Marcus Lindblom

Marcus Lindblom — Tue, 07 Apr 2009 11:49:53 +0000

For others who end up on this page, I’ve cloned Mads repo (as he knows) and changed some bits. It’s now available here and I’ll try to maintain it until the Trac-devs integrate a hook into trac releases.

http://bitbucket.org/marcusl/mercurial-trac-hook/

Comnments welcome. :)

By: Mads Sülau Jørgensen

Mads Sülau Jørgensen — Thu, 05 Feb 2009 09:04:26 +0000

I've pushed a new version of the hook now - just changed the count() to len(). Let me know if it should break something (it shouldn't).

Thanks Marcus!

By: Marcus Lindblom

Marcus Lindblom — Tue, 03 Feb 2009 08:13:16 +0000

Another fix. Starting at v1.1, Mercurial's changelog do not have a count() function anymore. Rather, you need to do use the len() built-in function.

I've patched my version for this. Some logic is probably needed to make it work for different versions of Hg.

By: Marcus Lindblom

Marcus Lindblom — Wed, 14 Jan 2009 08:55:25 +0000

I had to move to hg-ssh in cygwin to make things work, so then I got:

TypeError: '_demandmod' object is not iterable

I just disabled demandimport at the top of trachook.py, and this made things work again:

from mercurial import demandimport demandimport.disable()

One could probably be more selective in the disabling, but this seem to work for now.

By: Mads Sülau Jørgensen

Mads Sülau Jørgensen — Mon, 27 Oct 2008 20:05:01 +0000

There, updated at bitbucket. I’ve added an re.I to the match, which should fix it.

By: Mads Sülau Jørgensen

Mads Sülau Jørgensen — Mon, 27 Oct 2008 14:55:23 +0000

That's something that the orginal hook does as well. I'll update my version later tonight, as it's a very annoying "feature".

Thanks.

By: Marcus Lindblom

Marcus Lindblom — Mon, 27 Oct 2008 14:34:24 +0000

The hook works fine, but it isn’t case independent on commands. so ‘Fixes’ or ‘See’ doesn’t work.

Easy to add by appending .lower() on the call:

cmd_groups = command_re.findall(self.msg.lower())